Soldiers' healthbar misses pixel

[wl-zocker]

See attached screenshot. For the soldiers inside the building, the pixel on the top right of their lifebar is missing. For the soldiers outside, it is the pixel on bottom right.

[SirVer (sirver)]

That is some sharp eyes you have there. I think this is a regression.

[Hans Joachim Desserud (hjd)]

Nice catch. :)
Looking at the screenshot there's obviously an issue here, but I don't seem to be able to reproduce it in r6900. Could you check whether this is still reproducible, and possibly whether switching opengl rendering on/off makes a difference?

[wl-zocker (wl-zocker)]

Since I do not compile myself, I have to rely on Tino's builds (and he has some trouble compiling on Windows). Therefore the latest available build is r6890.
When OpenGL is enabled, the pixels are missing. When I disable it, both health bars are drawn correctly.

[wl-zocker (wl-zocker)]

Just one more update: The pixels are still missing in r6910. In build 18, it is like in the current development builds.
In build 17, the pixel has already been missing, but in both cases (inside and ouside of a military building), it was on the bottom right corner (therefore no regression). Obviously, my eyes are not that sharp.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Hans Joachim Desserud (hjd)]

I can't see this in r7199 on Ubuntu 14.04, with or without opengl enabled. Could you check whether you still have this issue? Might be a Windows- and/or opengl-driver issue.

[wl-zocker (wl-zocker)]

Still the same situation in r7199: With OpenGL, missing pixels. When disabled, all pixels are shown.

[Hans Joachim Desserud (hjd)]

Ok, thanks for checking. Is this on Windows? Could you check whether you see it on Ubuntu too?

[wl-zocker (wl-zocker)]

Yes, #8 is on windows. On Ubuntu, everything is fine.

[Hans Joachim Desserud (hjd)]

Ok, could you check which graphics driver you are running? (And maybe if there's a newer version of that driver, if that fixes the issue?)

[wl-zocker (wl-zocker)]

Some information attached, maybe it helps. According to the update function, I am using the latest version.
If no one else can reproduce this, I can also live with those missing pixels (they do not hinder gameplay that much).

[SirVer (sirver)]

I finally found out what this is causing: http://stackoverflow.com/questions/4532342/opengl-gl-lines-enpoints-not-joining

A fix could be to make a line loop with 5 points instead of only 4 to draw a rectangle.

[SirVer (sirver)]

Could/Should be fixed in 7343. Can somebody verify?

[wl-zocker (wl-zocker)]

No, it isn't. If you look at the attached screenshot from r7343, you see that the blue area does not even fill everything inside the white border (and the pixel at the corner is still missing).

[SirVer (sirver)]

Thanks for checking, I'll look into this again.

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.