NetApp iSCSI driver fails to create snapshot

[Jeff Applewhite]

When a cinder snapshot-create is issued the following error occurs:

2014-03-24 13:49:51.890 ERROR oslo.messaging.rpc.dispatcher [req-eabd71b6-17a5-4660-889b-dafe71b7ff4a 90dd8f9242ad4f72bcfd5bf88a54903d b534f90c77f14e6b8c24a0ae0320f0c6] Exception during message handling: NetApp api failed. Reason - 9017:No such LUN exists
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher Traceback (most recent call last):
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/oslo.messaging/oslo/messaging/rpc/dispatcher.py", line 133, in _dispatch_and_reply
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher incoming.message))
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/oslo.messaging/oslo/messaging/rpc/dispatcher.py", line 176, in _dispatch
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher return self._do_dispatch(endpoint, method, ctxt, args)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/oslo.messaging/oslo/messaging/rpc/dispatcher.py", line 122, in _do_dispatch
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher result = getattr(endpoint, method)(ctxt, **new_args)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 484, in create_snapshot
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher {'status': 'error'})
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/openstack/common/excutils.py", line 68, in __exit__
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher six.reraise(self.type_, self.value, self.tb)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/manager.py", line 475, in create_snapshot
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher model_update = self.driver.create_snapshot(snapshot_ref)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/drivers/netapp/iscsi.py", line 285, in create_snapshot
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher self._clone_lun(lun.name, snapshot_name, 'false')
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/drivers/netapp/iscsi.py", line 1386, in _clone_lun
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher luns = self._get_lun_by_args(path=clone_path)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/drivers/netapp/iscsi.py", line 1446, in _get_lun_by_args
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher result = self.client.invoke_successfully(lun_info, True)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher File "/opt/stack/cinder/cinder/volume/drivers/netapp/api.py", line 220, in invoke_successfully
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher raise NaApiError(code, msg)
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher NaApiError: NetApp api failed. Reason - 9017:No such LUN exists
2014-03-24 13:49:51.890 TRACE oslo.messaging.rpc.dispatcher

[Andrew Kerr (andrew-kerr)]

This appears to have been introduced by https://review.openstack.org/79614 (oops!)

We need to add a check to make sure if z_calls = 0 then we set z_calls to 1.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82621
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=af4a58d672cfa0c4b63015e7e783461570296c76
Submitter: Jenkins
Branch: master

commit af4a58d672cfa0c4b63015e7e783461570296c76
Author: Jeff Applewhite <email address hidden>
Date: Mon Mar 24 17:37:22 2014 -0400

    Netapp iscsi: allow snapshots with unspecified block range.

    Snapshots were failing to create in all cases in the NetApp iscsi
    driver. The clone lun function was never issuing the zapi call
    because the block count was set to 0.

    Closes-Bug: 1296881

    Change-Id: Ic2bf67b57a566632103a3fa2ff032555f42a3961

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alan Pevec (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/78347
Reason: Final Havana release 2012.3.4 has been cut and stable/havana is going to be removed in a week.