VMware: InvalidDiskFormat when booting from volume

[Ryan Hsu]

Using the VC Driver, an InvalidDiskFormat is seen when attempting to boot from a volume. The scenario is:

1. Create a volume of any size
2. Boot from the volume

The following error message is seen:

Traceback (most recent call last):
  File "/opt/stack/nova/nova/compute/manager.py", line 1306, in _build_instance
    set_access_ip=set_access_ip)
  File "/opt/stack/nova/nova/compute/manager.py", line 394, in decorated_function
    return function(self, context, *args, **kwargs)
  File "/opt/stack/nova/nova/compute/manager.py", line 1708, in _spawn
    LOG.exception(_('Instance failed to spawn'), instance=instance)
  File "/opt/stack/nova/nova/openstack/common/excutils.py", line 68, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/nova/nova/compute/manager.py", line 1705, in _spawn
    block_device_info)
  File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 611, in spawn
    admin_password, network_info, block_device_info)
  File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 223, in spawn
    (file_type, is_iso) = self._get_disk_format(image_meta)
  File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 189, in _get_disk_format
    raise exception.InvalidDiskFormat(disk_format=disk_format)
InvalidDiskFormat: Disk format None is not acceptable

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82616

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82616
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7ccddf002ceac7e299a5b612ccbe7b63f6f84b2c
Submitter: Jenkins
Branch: master

commit 7ccddf002ceac7e299a5b612ccbe7b63f6f84b2c
Author: hartsocks <email address hidden>
Date: Mon Mar 24 14:35:24 2014 -0700

    VMware: fix booting from volume

    Instances that are boot from volume can be disk_format of None.
    This change allows for that.

    Change-Id: Id83083096460cb2e4a5367c8df15daa9f788292c
    Closes-bug: 1296874