Incorrect nullable parameter in models

Bug #1296282 reported by Ann Taraday
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Ann Taraday

Bug Description

In some models value of 'nullable' parameter in columns is wrong. The following models are incorrect:
NULL for PoolLoadbalancerAgentBinding agent_id
NULL for NexusPortBinding switch_ip and instance_id
NULL for LsnPort lsn_id
NULL for NeutronNsxPortMapping nsx_port_id
NULL for TzNetworkBinding phy_uuid and vlan_id as they are primary keys
Migration 492a106273f8_brocade_ml2_mech_dri sets admin_state_up NULL in ml2_brocadeports instead of NOT NULL.
In migrations folsom_initial was set incorrect nullable parameter for vlan_id in cisco_nexusport_bindings.

This can be checked as it is shown there http://paste.openstack.org/show/74091/ http://paste.openstack.org/show/76628/.

Changed in neutron:
assignee: nobody → Ann Kamyshnikova (akamyshnikova)
description: updated
Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/89496

description: updated
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/89496
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a2d7de8669016fa9d84de7b68050737a32dee7bd
Submitter: Jenkins
Branch: master

commit a2d7de8669016fa9d84de7b68050737a32dee7bd
Author: Ann Kamyshnikova <email address hidden>
Date: Tue Apr 22 11:22:24 2014 +0400

    Ml2: Set correct nullable for admin_state_up

    In migrations 492a106273f8_brocade_ml2_mech_dri was set incorrect
    nullable parameter:

    Set admin_state_up NOT NULL in ml2_brocadeports.

    Partial-Bug: #1296282

    Change-Id: I051e37990ae3371978eeb1ff71e70ae2a44097bc

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/89497
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2d4a2fa884ebda4ef6770bdc5729cac02d1f33fa
Submitter: Jenkins
Branch: master

commit 2d4a2fa884ebda4ef6770bdc5729cac02d1f33fa
Author: Ann Kamyshnikova <email address hidden>
Date: Tue Apr 22 11:34:18 2014 +0400

    Cisco: Set correct nullable for switch_ip, instance_id, vlan_id

    Corrected the following model according to database
    content:
     - NOT NULL for NexusPortBinding switch_ip and instance_id

    In migrations folsom_initial was set incorrect nullable parameter:
    - Set vlan_id NOT NULL in cisco_nexusport_bindings.

    Partial-Bug: #1296282

    Change-Id: Ie5315fcbf227025c30ab4a4b97ec2a140ee3923c

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/89498
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a4e1ad0cb55c48acbae59f222cd24e268ea495d8
Submitter: Jenkins
Branch: master

commit a4e1ad0cb55c48acbae59f222cd24e268ea495d8
Author: Ann Kamyshnikova <email address hidden>
Date: Tue Apr 22 11:40:36 2014 +0400

    Vmware: Set correct nullable for lsn_id, nsx_port_id

    Corrected the following models according to database
    content:
    - NOT NULL for LsnPort lsn_id;
    - NOT NULL for NeutronNsxPortMapping nsx_port_id;

    Partial-Bug: #1296282

    Change-Id: Ia67fcc68eeceb27d9274adb652ab45b32152f01c

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/82089
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8ec571e1d1d66da3c31b3f8d4c576e966fde42b7
Submitter: Jenkins
Branch: master

commit 8ec571e1d1d66da3c31b3f8d4c576e966fde42b7
Author: Ann Kamyshnikova <email address hidden>
Date: Fri Mar 21 17:08:23 2014 +0400

    LBaaS: Set correct nullable parameter for agent_id

    Corrected the following model according to database
    content:
     - NOT NULL for PoolLoadbalancerAgentBinding agent_id;

    Partial-bug: #1296282

    Change-Id: I1f11ec2e8f4c16f58dd8d4e6429e46eaedaec945

Changed in neutron:
status: In Progress → Fix Committed
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.