bitcrusher downsampling knob doesn't do much until the very end of the rotation

Bug #1296088 reported by Owen Williams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Daniel Schürmann

Bug Description

The downsampling knob doesn't crush very much (make an audible change) until the very last few degrees of the knob's rotation. Probably it should be logarithmic.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

+1, log support isn't finished yet

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Daniel Schürmann (daschuer)
Changed in mixxx:
status: Confirmed → Fix Committed
Revision history for this message
Owen Williams (ywwg) wrote :

This still doesn't seem like it's working right, can you post a link to the commit that fixed this?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

This commit fixes the issue for me.
https://github.com/daschuer/mixxx/commit/573060b807113156d1e8b9106f58b42d4f36a0fb

But maybe it is not enough. The "problem" for the bitcrusher is, that you need good speakers and good ears the notice differences between 16 and 8 bit. 8 bit is now at a quarter instead of half.

Revision history for this message
Owen Williams (ywwg) wrote :

Thanks, I'll tweak this (and the other effects) a bit.

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Hi Owen,

fixing this or similar bug in other effects. moves towards a "taste" discussion, we should avoid.

Can you outline your idea to fix this?

I am as well not entirely satisfied with the effect, but mainly how the super knob acts on down sampling and the bit depth knob.

IMHO a good strategy to make the single parameter knob almost natural and move the "taste" part to a tweaked or later tweak-able scaled mapping of the super knob.

So a possible solution for this might be:
1. consider if we need a third scaling for knobs in addition to linear and logarithmic (one decade), but keep the value natural range from 1 to 16 in case of bit depth.
2. add a probably non linear scale to the super knob mapping, to produce a nice effect. For this, we need a conclusion how to achieve it.
Any Ideas?

Kind regards,

Daniel

Revision history for this message
Owen Williams (ywwg) wrote :

I have no problem inventing magic numbers and tweaking the effect until it sounds good to me -- that's how I've approached most of the features I've written. I usually try things over and over and tweak until it sounds good. I think the best software makes choices for its users when it makes sense to do so. This is one of the benefits of writing one's own software -- sometimes I get to decide that my taste is better :).

At the most basic level, I want to make sure that as much of the range of the knob is useful as possible. If I find that I have to move it really slowly because the change is too coarse, I'm going to tweak it so I can be looser. I don't think I should have to get approval for a perfect mathematical formula to do it. My idea for how to fix this is: I will play with it for a while until it sounds right.

Revision history for this message
Owen Williams (ywwg) wrote :

The log change was good. I also tweaked the limits so it doesn't fall off a cliff at the end of the range (it actually went silent before!).

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you,
I am working on a tweak-able scale knob, that allows to set the dB range and the neutral position.
I hope we can use it to tweak the effect a bit more.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7348

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.