fix create_or_update logic to avoid rollbacks

Bug #1295504 reported by gordon chung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Medium
gordon chung

Bug Description

related to deprecation bug: https://bugs.launchpad.net/ceilometer/+bug/1257530

ceilometer code blindly adds entries to sql tables without check existence first... this causes massive amount of rollbacks.

add a check before anything.

gordon chung (chungg)
Changed in ceilometer:
milestone: none → icehouse-rc1
Changed in ceilometer:
assignee: nobody → gordon chung (chungg)
status: New → In Progress
gordon chung (chungg)
Changed in ceilometer:
importance: Undecided → Medium
Revision history for this message
Julien Danjou (jdanjou) wrote :

Is there a patch?

Changed in ceilometer:
status: In Progress → Triaged
Revision history for this message
Ildiko Vancsa (ildiko-vancsa) wrote :

Hi Julien,

Here is the patch: https://review.openstack.org/#/c/81969/ , so I set the status back to In Progress. I assume the bug report update did not worked properly this time after the patch was uploaded to review.

Best Regards,
Ildiko

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/81969
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=21237b333ca2e6766a74dc28c5f788160349a9ce
Submitter: Jenkins
Branch: master

commit 21237b333ca2e6766a74dc28c5f788160349a9ce
Author: Gordon Chung <email address hidden>
Date: Thu Mar 20 22:46:37 2014 -0400

    fix create_or_update logic to avoid rollbacks

    check if entry exists rather than blindly adding entries to table.
    this will avoid unnecessary rollback overhead.

    Closes-Bug: #1295504
    Change-Id: I923cc35ed4c9155ffa04ac189555cdbcb38bcbcf

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.