crash on dotted lines in some EMF files, sometimes

Bug #1294840 reported by David Mathog
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Undecided
David Mathog

Bug Description

In certain EMF files dotted lines crash Inkscape. Example attached. This was variable as it involved a memory access violation that might or might not occur depending upon what preceded it, and probably varied a bit from compilation to compilation.

Patch in next post.

Revision history for this message
David Mathog (mathog) wrote :
Revision history for this message
David Mathog (mathog) wrote :

This patch eliminates the access violation. The problem was that it should have been using

  style.stroke_dasharray.values.push_back( dash_length );

but was instead doing

  style.stroke_dasharray.values[ i ]= dash_length;

and this would crash depending upon if something else had already made values long enough to hold the result for that "i".

Revision history for this message
David Mathog (mathog) wrote :

Slightly modified patch, takes out some extraneous lines.

Committed as revision 13318

Revision history for this message
David Mathog (mathog) wrote :

Status new -> fix committed

Changed in inkscape:
status: New → Fix Committed
su_v (suv-lp)
Changed in inkscape:
assignee: nobody → David Mathog (mathog)
milestone: none → 0.91
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.