FibreChannelDriver doesn't implement validate_connector

Bug #1294812 reported by Walt Boring
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Mark Sturdevant

Bug Description

The base FibreChannelDriver doesn't implement the validate_connector() method. It falls back to the parent class which simply does a pass. The FC Driver should do a check on the connector and ensure that is has wwnns, wwpns to ensure that the child classes can actually do a volume attach. Without wwnns, wwpns, no FC driver can successfully do initialize_connection.

Changed in cinder:
assignee: Walt Boring (walter-boring) → Mark Sturdevant (mark-sturdevant)
description: updated
Changed in cinder:
milestone: next → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/90442

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/90442
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=bdfc450f59a6b73c1548734e0a5cca5a9e6256ab
Submitter: Jenkins
Branch: master

commit bdfc450f59a6b73c1548734e0a5cca5a9e6256ab
Author: Mark Sturdevant <email address hidden>
Date: Fri Apr 25 10:58:42 2014 -0700

    Implement validate_connector in FibreChannelDriver

    The base FibreChannelDriver didn't implement the
    validate_connector() method. It fell back to the
    parent class which simply does a pass. Now the
    FCDriver checks to ensure that the connector has
    wwnns and wwpns and raises an exception if either
    one is empty or not set.

    Closes-Bug: #1294812

    Change-Id: I1e63c4718d24bdb3ead78de871971cdc498f6b01

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.