schema for AWS::AutoScaling::AutoScalingGroup's VPCZoneIdentifier should say length=1

[Mike Spreitzer]

Only the first member of the list is used.

[Mike Spreitzer (mike-spreitzer)]

Fix by adding
            constraints=[
                constraints.Length(min=1, max=1)
            ]
to the schema for that property.

[Mike Spreitzer (mike-spreitzer)]

Might as well fix up the description too.

[Mike Spreitzer (mike-spreitzer)]

Here is what I suggest:

        VPCZONE_IDENTIFIER: properties.Schema(
            properties.Schema.LIST,
            _('Use only with Neutron.'),
            constraints=[
                constraints.Length(min=1, max=1)
            ],
            schema=properties.Schema(
                properties.Schema.STRING,
                _('UUID of the internal subnet to which the instance will be attached.')
            )
        ),

[Steve Baker (steve-stevebaker)]

I'm very happy to have this property better documented. Could you please submit this change to gerrit?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81605

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81638

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81727

[Pavlo Shchelokovskyy (pshchelo)]

could you abandon the first two not to confuse reviewers? looks like you are just getting used to Gerrit workflow :)

[Mike Spreitzer (mike-spreitzer)]

Done. I have gotten this right before, but don't remember an important detail now.
When I commit the second patch set, do I keep the change ID from the first or omit a change ID
in the commit message?

[Pavlo Shchelokovskyy (pshchelo)]

when you change your patch set you commit with --amend, so that there is always only one commit on you branch and do not change/remove Change-Id while you edit the commit message - Change-Id is what identifies a patch-set to Gerrit, so that commits with the same Change-Id are treated as belonging to one evolving patch-set. If you remove Change-Id from the commit message, git review hook will still insert one, but this time different.

Good read: https://wiki.openstack.org/wiki/GerritWorkflow

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/81727
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=8902c6e331f2d5f6c4b764d5674c2789439896b9
Submitter: Jenkins
Branch: master

commit 8902c6e331f2d5f6c4b764d5674c2789439896b9
Author: Mike Spreitzer <email address hidden>
Date: Wed Mar 19 19:25:46 2014 +0000

    Refined schema for VPCZoneIdentifier

    The schema now says it is a list of strings. Also upgraded the
    description. Also clarified the name of
    test_invalid_vpc_zone_identifier.

    Change-Id: I4b17dbd146965df3df3f4205dddafc0b65061294
    Closes-Bug: #1294717