Admin mgmt API requires rate limiting for POSTs

Bug #1294421 reported by Dan Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Dan Nguyen

Bug Description

As we are looking to allow the admin API to send upgrade notification requests to guest agents there will be a need to throttle or rate limit request so we don't flood the system.

This would only require extending the rate limits feature to match the */mgmt/* URL's with a set of rules for each supported HTTP method.

The number of requests can be abstracted to a config file in the same way that the non-admin API rate limits are set.

Revision history for this message
Dan Nguyen (daniel-a-nguyen) wrote :
Changed in trove:
assignee: nobody → Dan Nguyen (daniel-a-nguyen)
summary: - Admin mgmt API requires rate limiting
+ Admin mgmt API requires rate limiting for POSTs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81557

Changed in trove:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/81557
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=d07c8c0445dca42ef5a27bbf945b9f99a4995aab
Submitter: Jenkins
Branch: master

commit d07c8c0445dca42ef5a27bbf945b9f99a4995aab
Author: daniel-a-nguyen <email address hidden>
Date: Wed Mar 19 08:30:47 2014 -0700

    Added separate rate limit setting for mgmt POST

    Created a simple unittest
    Fixed typo granced --> granted
    Fixed test to show that the 4th request will result in a delay

    Change-Id: I95062a805aaae88432c081d5f1d0a2da81d7108c
    Closes-Bug: #1294421

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: none → juno-1
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.