Neutron requires admin acess to Nova to do vif plug callback

[James Slagle]

It seems Neutron requires admin access to Nova in order to do a callback once the vif plug is available. This is breaking the tripleo CI overcloud jobs currently.

We need to make the following equivalent configuration changes to neutron.conf as happened in devstack:
https://review.openstack.org/#/c/78044/7/lib/neutron

[James Slagle (james-slagle)]

Does neutron really need admin privileges to do this?

[James Slagle (james-slagle)]

appears we have to add admin tenant id to neutron.conf, however that's not known until init-keystone has run

[James Slagle (james-slagle)]

This requirement introduced by:
https://review.openstack.org/#/c/74832/26

[James Slagle (james-slagle)]

relevant CI logs:
/var/log/upstart/nova-compute.log from http://logs.openstack.org/16/78816/3/check-tripleo/check-tripleo-overcloud-precise/a0c8d54/192.0.2.4_logs.tgz
/var/log/upstart/neutron-server.log and /var/log/upstart/nova-api.log from http://logs.openstack.org/16/78816/3/check-tripleo/check-tripleo-overcloud-precise/a0c8d54/192.0.2.5_logs.tgz

[Aaron Rosen (arosen)]

@James, yes this is an admin only api that nova exposes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81120

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81224
Committed: https://git.openstack.org/cgit/openstack/tripleo-image-elements/commit/?id=e234bddee9834a389520754062153e1a4df6af3b
Submitter: Jenkins
Branch: master

commit e234bddee9834a389520754062153e1a4df6af3b
Author: Derek Higgins <email address hidden>
Date: Tue Mar 18 10:50:09 2014 +0000

    Treat failure to hear back from neutron as non fatal

    A recent change to nova requires neutron to have admin credentials in
    order to report back to nova that VIF plugging is complete. Our neutron
    doesn't have the appropriate credentials and adding them isn't trivial
    as we don't know the tenant id when we do the heat stack-create of the
    overcloud.

    This commit should be considered a temporary workaround that disables the
    requirement, this will unblock ci while we figure out how to handle the
    problem correctly.

    Related-Bug: #1293782

    Change-Id: I1a31d31e3d3ab923217eaf3b2e865a28dd57ec44

[James Slagle (james-slagle)]

dropping to High as there is a workaround

[Stephen Ma (stephen-ma)]

Based on the review comments made to the last code review submitted to fix this problem, the name of the nova admin tenant cannot be passed-in as the "nova_admin_tenant_id". It needs to be passed in as a parameter called "nova_admin_tenant_name". This parameter is added by neutron code review https://review.openstack.org/103978. Currently this review is still in progress. Once the changes from review 103978 is merged. I will resubmit the patch with the correction.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/126570

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/126570
Committed: https://git.openstack.org/cgit/openstack/tripleo-image-elements/commit/?id=0268b725385ad098dd874c3d92923089b3120b64
Submitter: Jenkins
Branch: master

commit 0268b725385ad098dd874c3d92923089b3120b64
Author: Stephen Ma <email address hidden>
Date: Tue Oct 7 14:38:30 2014 +0000

    Add Nova Admin access to neutron.conf

    Add Nova admin access information to Neutron to allow it to do
    vif callbacks.

    Change-Id: I1889662f74a8da8c4ccfc46f0ccf8e73e9acb74b
    Closes-Bug: #1293782