NSX: Gateway devices can't be updated after an upgrade

[Salvatore Orlando]

Also, they can only be accessed by admin users whereas the should be in the scope of the tenant who owns the network gateway service.

The gateway device database migration upon an upgrade creates gateway devices objects from references in network gateway
objects. While these gateway devices are perfectly usable in network gateways, they are not directly visible to tenants and also cannot be updated.

Upon any attempt to perform an update, a 500 is indeed returned unless all the attributes are specified (with the exception of the client certificate)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80989

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80989
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fb5bef8f53e80c1cbd7e570d26651723d4ff599c
Submitter: Jenkins
Branch: master

commit fb5bef8f53e80c1cbd7e570d26651723d4ff599c
Author: Salvatore Orlando <email address hidden>
Date: Mon Mar 17 15:43:53 2014 +0100

    NSX: Ensure gateway devices are usable after upgrade

    The gateway device database migration upon an upgrade creates
    gateway devices objects from references in network gateway
    objects.
    While these gateway devices are perfectly usable
    in network gateways, they are not directly visible to tenants
    and also cannot be updated to change details such as name,
    connector type or ip as well as the client certificate.

    This patch fixes the DB migration in order to ensure tenant
    have access to gateway devices created after an upgrade.
    This patch also modifies the l2 gateway nsxlib module to
    ensure request bodies are correctly created even when not all
    the attributes of a gateway device are specified.

    Change-Id: I7077e9884adc739fb75e64a6e9a17a124d79fb6b
    Closes-Bug: 1293617