mysql table charset and engine options won't work

Bug #1293409 reported by Mehdi Abaakouk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
High
Mehdi Abaakouk

Bug Description

Hi,

The code here is broken:

http://git.openstack.org/cgit/openstack/ceilometer/tree/ceilometer/storage/sqlalchemy/models.py#n48

table_args() is run at module load time, before cfg.CONF is initialized, so the cfg.CONF contains the default value, not the one in the configuration file.

The mysql_charset and mysql_engine are never set, because the default connection configuration is sqlite://

Cheers

Mehdi Abaakouk (sileht)
Changed in ceilometer:
assignee: nobody → Mehdi Abaakouk (sileht)
Changed in ceilometer:
status: New → In Progress
Mehdi Abaakouk (sileht)
description: updated
description: updated
Changed in ceilometer:
assignee: Mehdi Abaakouk (sileht) → Alexei Kornienko (alexei-kornienko)
Changed in ceilometer:
assignee: Alexei Kornienko (alexei-kornienko) → gordon chung (chungg)
gordon chung (chungg)
Changed in ceilometer:
assignee: gordon chung (chungg) → Mehdi Abaakouk (sileht)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/78132
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=5f953e2765f8a20eebd20779316944e2a4221c94
Submitter: Jenkins
Branch: master

commit 5f953e2765f8a20eebd20779316944e2a4221c94
Author: Mehdi Abaakouk <email address hidden>
Date: Fri Mar 14 13:37:03 2014 +0100

    Sync oslo-incubator code

    Sync code to commit: b7ad6ddab8b1d61bf4f52ccaa461a9d68809747b

    The oslo db API have been changed, so sqlalchemy driver have been updated
    to match these changes.
    We now use sqlalchemy/migration.py from oslo.db instead of the
    ceilometer one.
    The unused alembic code have been removed, because it is handled by
    oslo.db now.

    Closes bug: #1293409

    Change-Id: I480d678a7165f32b92c5c9b4c55491c0edbc0991

Changed in ceilometer:
status: In Progress → Fix Committed
Eoghan Glynn (eglynn)
Changed in ceilometer:
milestone: none → juno-1
importance: Undecided → High
Thierry Carrez (ttx)
Changed in ceilometer:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.