Don't import guestfs directly

Bug #1293298 reported by ChangBo Guo(gcb)
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Unassigned

Bug Description

Library guestfs is not in requirements file, but is imported directly
in nova/virt/disk/vfs/guestfs.py. That conflicts with global variable
guestfs, leads out one more time import and shadow issue, so remove it
from import group.

Revision history for this message
Sahid Orentino (sahid-ferdjaoui) wrote :

There is something strange, I don't understand why we try to import guestfs and then set it to None to import it locally.
I confirm it because I feel there is something that can be improve.

Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
ChangBo Guo(gcb) (glongwave) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/80741
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4ecc1c52dbe02d5c4211d3936e2eec57dcc22de3
Submitter: Jenkins
Branch: master

commit 4ecc1c52dbe02d5c4211d3936e2eec57dcc22de3
Author: ChangBo Guo(gcb) <email address hidden>
Date: Sat Mar 15 10:17:24 2014 +0800

    Don't import library guestfs directly

    Library guestfs is not in requirements file, but is imported directly
    in nova/virt/disk/vfs/guestfs.py. That conflicts with global variable
    guestfs, leads out one more time import and shadow issue, so remove it
    from import group.

    Closes-Bug: #1293298

    Change-Id: I55530ed682ebf449673759ab6127bcd28cb92594

Changed in nova:
status: Confirmed → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.