get_resource_or_fake method in VPN panel is no longer unnecessary

Bug #1292998 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

get_resource_or_fake method in VPN panel is introduced to expand related VPN resources or subnet/router names to minimize the changes in late Havana cycle, but after that similar resource expansion is introduced to api/vpn.py too. It is common in LBaaS/FWaaS/VPNaaS code, so it is better to remove get_resource_or_fake method in VPNaaS to reduce code duplication.

Tags: vpnaas
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80810

Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80810
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=92a8df223af1193c0477a806438273fa0a3cfd72
Submitter: Jenkins
Branch: master

commit 92a8df223af1193c0477a806438273fa0a3cfd72
Author: Akihiro Motoki <email address hidden>
Date: Sun Mar 16 08:44:57 2014 +0900

    Remove get_resource_or_fake method in VPN panel

    api/vpn.py now expands related resources now.
    get_resource_or_fake method is no longer required.

    Closes-Bug: #1292998
    Change-Id: I45d049f7ccc3a4be7a6bfb08cbd8de650d4344de

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.