nova.volume.cinder.API incorrectly derives from nova.db.base.Base

Bug #1292997 reported by Jay Pipes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Unassigned

Bug Description

For some reason, nova.volume.cinder.API derives from nova.db.base.Base, which looks like this (in its entirety):

class Base(object):
    """DB driver is injected in the init method."""

    def __init__(self, db_driver=None):
        super(Base, self).__init__()
        if not db_driver:
            db_driver = CONF.db_driver
        self.db = importutils.import_module(db_driver) # pylint: disable=C0103

I checked and nova.volume.cinder.API makes no reference at all to self.db, therefore unless I am mistaken, there's no reason for this inheritance.

Revision history for this message
Christopher Yeoh (cyeoh-0) wrote :
Changed in nova:
status: New → Confirmed
importance: Undecided → Low
Tiago Mello (timello)
Changed in nova:
assignee: nobody → Tiago Rodrigues de Mello (timello)
assignee: Tiago Rodrigues de Mello (timello) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/80859
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=048cd541c7066185b3802bded7b2f009859443c3
Submitter: Jenkins
Branch: master

commit 048cd541c7066185b3802bded7b2f009859443c3
Author: Jay Pipes <email address hidden>
Date: Sun Mar 16 19:37:37 2014 -0400

    Correct inheritance of nova.volume.cinder.API

    nova.volume.cinder.API was deriving incorrectly from nova.db.base. This
    patch simply removes that unnecessary import and changes
    nova.volume.cinder.API to derive from object instead.

    Change-Id: I5092b7fbb3780317a09a512aed7ecbe1d57a4428
    Closes-bug: #1292997

Changed in nova:
status: Confirmed → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.