Update stack fails because of unresolved parameters were used

[Sergey Kraynev]

I have stack is described next template:

HeatTemplateFormatVersion: '2012-12-12'
Description: |
  Template which tests neutron load balancing resources
Parameters:
  key_name:
    Type: String
    flavor:
    Type: String
  image:
    Type: String
  private_subnet_id:
    Type: String
  external_network_id:
    Type: String
Resources:
  TestHealthMonitor:
    Type: OS::Neutron::HealthMonitor
    Properties:
      delay: 3
      type: HTTP
      timeout: 3
      max_retries: 3
  TestHealthMonitor2:
    Type: OS::Neutron::HealthMonitor
    Properties:
      delay: 3
      type: HTTP
      timeout: 3
      max_retries: 3
  TestPool:
    Type: OS::Neutron::Pool
    Properties:
      lb_method: ROUND_ROBIN
      protocol: HTTP
      subnet_id: {Ref: private_subnet_id}
      vip:
        protocol_port: 80
      monitors:
      - {Ref: TestHealthMonitor}
      - {Ref: TestHealthMonitor2}

Then I remove one of the references ( -{Ref: TestHealthMonitor2} ), and try update my stack.
As result I have got error next trace back: http://paste.openstack.org/show/73489/

[Sergey Kraynev (skraynev)]

The problem is connected with unresolved properties. The old template stored values, which were parsed using resolve_static_data : https://github.com/openstack/heat/blob/master/heat/engine/resources/neutron/loadbalancer.py#L386

So instead resolved monitors id we have only built-in functions.
In my vision, we should use self.properties for getting required properties.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80569

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80961

[Steve Baker (steve-stevebaker)]

Depends on bug 1291411

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/80569
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=61b804a861d27bb10bc14c778ad7d489ed42f24d
Submitter: Jenkins
Branch: master

commit 61b804a861d27bb10bc14c778ad7d489ed42f24d
Author: Sergey Kraynev <email address hidden>
Date: Fri Mar 14 09:33:12 2014 -0400

    Using resolving properties for update

    For definition reference in template we should use built-in functions.
    So template after parsing with resolve_static_data will contain
    references on these functions instead resolve values.
    If we want get some information about previous state of stack during
    update, we should use self.properties instead of self.t['Properties'].
    Also default=[] was added to avoid error when we try to do set([]).

    Closes-bug: #1292495
    Change-Id: I0cc44a0a541913cca665caec1a7f3a2a1a6cebc9