fake nova_client redefines the volumes while creating fake_nova_client

Bug #1292457 reported by Sushil Kumar
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Sushil Kumar

Bug Description

https://github.com/openstack/trove/blob/master/trove/tests/fakes/nova.py#L793 defines
nova_client.volumes = volume_client

also volume in nova_client is defined as https://github.com/openstack/trove/blob/master/trove/tests/fakes/nova.py#L770

This makes volumes APIs with nova_client accessible as nova_client.volumes.volumes

This should be nova_client.volumes, instead.

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80536

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/80536
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=53182ddb06328d7c29f651b405f677a023b4c608
Submitter: Jenkins
Branch: master

commit 53182ddb06328d7c29f651b405f677a023b4c608
Author: Sushil Kumar <email address hidden>
Date: Fri Mar 14 10:48:18 2014 +0000

    Removes volumes redefinition in fake nova_client

    Reasons:
    - The redefinition of nova_client.volumes was making it,
      nova_client.volumes.volumes, if we needed to call the volume APIs
      from nova_client.
    - nova_client.volumes is already defined when defining "class FakeClient".

    Changes:
    - Removes redefinition of nova_client.volumes.

    Change-Id: I5981d461e5a0fd000214c35d5d0be58d86d6d368
    Closes-Bug: #1292457

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
importance: Undecided → Medium
milestone: none → juno-1
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.