Exception handle in be better when create a flavor

[jichenjc]

If I create a flavor but failed to operate on db layer , a InstanceTypeCreateFailed exception will be raised but
nova-api didn't handle it well, it will report

[root@controller ~]# nova flavor-create test1 111 512 1 1
ERROR: The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID: req-74050da0-6f78-408e-8a1b-97c2a03e597d)

give more accurate reason will be better

[Leandro Ignacio Costantino (leandro-i-costantino)]

I thinks this is being addressed by https://review.openstack.org/#/c/66187/

[Leandro Ignacio Costantino (leandro-i-costantino)]

Disregard my last comment, it's only for flavor extraspecs

[jichenjc (jichenjc)]

The exception is 'FlavorCreateFailed' now

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/95059

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/95059
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e0844f257cd170d01255aa3f8bfd48ff50731f16
Submitter: Jenkins
Branch: master

commit e0844f257cd170d01255aa3f8bfd48ff50731f16
Author: jichenjc <email address hidden>
Date: Sun Apr 13 13:29:56 2014 +0800

    Handle a flavor create failed better

    Catch FlavorCreateFailed exceptions which when flavor creation fails.
    This type of flavor creation failure is caused by an internal nova problem.
    Return an internal server error (500) to the user so they know
    to contact their cloud provider.

    Closes-Bug: #1292309

    Change-Id: I268c84dae290b0170448d789509af781555df9b0