Log statement for updating info cache needs to be moved

Bug #1292298 reported by Aaron Rosen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Aaron Rosen

Bug Description

From the logs I notice that it says we are updating the info cache with None though that is not always true as if nw_info is not an instance of we NetworkInfo query neutron and then save that.

2014-03-13 02:57:19.647 DEBUG nova.network.api [req-9df20a08-37e1-4b67-94a9-963e6f6110ef TestVolumeBootPattern-554767810 TestVolumeBootPattern-64159061] Updating cache with info: None update_instance_cache_with_nw_info /opt/stack/new/nova/nova/network/api.py:70
2014-03-13 02:57:19.647 DEBUG nova.network.neutronv2.api [req-9df20a08-37e1-4b67-94a9-963e6f6110ef TestVolumeBootPattern-554767810 TestVolumeBootPattern-64159061] get_instance_nw_info() for scenario-server--1401642137 _get_instance_nw_info /opt/stack/new/nova/nova/network/neutronv2/api.py:463

Tags: network
Aaron Rosen (arosen)
Changed in nova:
assignee: nobody → Aaron Rosen (arosen)
importance: Undecided → Low
tags: added: network
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80438

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/80438
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e63893ecb6ea031df081f9f429a157969abfa47f
Submitter: Jenkins
Branch: master

commit e63893ecb6ea031df081f9f429a157969abfa47f
Author: Aaron Rosen <email address hidden>
Date: Thu Mar 13 18:20:57 2014 -0700

    Move log statement to expose actually info_cache value

    When debugging an info_cache issue I noticed the logs display:

    "Updating cache with info: None update_instance_cache_with_nw_info"

    Though we are not actually updating the info_cache with None as if
    nw_info is not isinstance(NetworkInfo we fetch the latest nw_info
    from neturon. This patch just moves the log statement so the actual
    value is exposed.

    Change-Id: I3a74191c31a053682bb2558c59228025ceb0cf28
    Closes-bug: 1292298

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.