A few tests from test_sqlalchemy_utils fail on SQLAlchemy 0.9.x

Bug #1292284 reported by Roman Podoliaka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Roman Podoliaka
oslo-incubator
Fix Released
Medium
Roman Podoliaka

Bug Description

When SQLAlchemy 0.9.x releases are used, some tests from test_sqlalchemy_utils module fail on assertRaises(). This is caused by the fact that we except SQLAlchemy to raise exceptions when reflecting SQLite custom data types from existing DB schema. This was true for SA 0.7.x and 0.8.x branches, but is fixed in 0.9.x releases.

Tags: db
Changed in nova:
assignee: nobody → Roman Podoliaka (rpodolyaka)
tags: added: db
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80432

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/80432
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=64d96694c3c0af7a24084f8c520ba89680ab304f
Submitter: Jenkins
Branch: master

commit 64d96694c3c0af7a24084f8c520ba89680ab304f
Author: Roman Podoliaka <email address hidden>
Date: Fri Mar 14 00:55:10 2014 +0200

    Fix sqlalchemy utils test cases for SA 0.9.x

    To be able to run migration scripts on SQLite we've been providing
    a few workarounds for sqlalchemy-migrate and SQLAlchemy 0.7.x and
    0.8.x branches in the form of sqlalchemy utils module. In 0.9.x
    releases a few workarounds become obsolete (due to improvements made
    to schema reflection for SQLite in SA), but our test cases still
    expect SA to raise exceptions in several cases.

    As long as our utils can work well with 0.9.x SA releases with our
    workarounds and without them, we can just skip the test cases
    expecting exceptions to be raised when SA version > 0.9.0 is used
    and continue to run them for older releases of SA.

    Closes-Bug: #1292284

    Change-Id: Ie6cdb017b64b393cff43957b2047b5aae142d54e

Changed in nova:
status: In Progress → Fix Committed
Ben Nemec (bnemec)
Changed in oslo:
importance: Undecided → Medium
status: New → Triaged
Changed in nova:
milestone: none → icehouse-rc1
Changed in oslo:
assignee: nobody → Roman Podoliaka (rpodolyaka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo-incubator (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81493

Changed in oslo:
status: Triaged → In Progress
Changed in oslo:
assignee: Roman Podoliaka (rpodolyaka) → Ben Nemec (bnemec)
Ben Nemec (bnemec)
Changed in oslo:
assignee: Ben Nemec (bnemec) → Roman Podoliaka (rpodolyaka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo-incubator (master)

Reviewed: https://review.openstack.org/81493
Committed: https://git.openstack.org/cgit/openstack/oslo-incubator/commit/?id=f13b456289224fbe4711d047034f850210437101
Submitter: Jenkins
Branch: master

commit f13b456289224fbe4711d047034f850210437101
Author: Roman Podoliaka <email address hidden>
Date: Wed Mar 19 12:51:13 2014 +0200

    Fix sqlalchemy utils test cases for SA 0.9.x

    To be able to run migration scripts on SQLite we've been providing
    a few workarounds for sqlalchemy-migrate and SQLAlchemy 0.7.x and
    0.8.x branches in the form of sqlalchemy utils module. In 0.9.x
    releases a few workarounds become obsolete (due to improvements made
    to schema reflection for SQLite in SA), but our test cases still
    expect SA to raise exceptions in several cases.

    As long as our utils can work well with 0.9.x SA releases with our
    workarounds and without them, we can just skip the test cases
    expecting exceptions to be raised when SA version > 0.9.0 is used
    and continue to run them for older releases of SA.

    Closes-Bug: #1292284

    Change-Id: Ic1453de16ec191f162d5604df76510d56429b32d

Changed in oslo:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: none → icehouse-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-rc1 → 2014.1
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.