HA scenarios set wrong openstck_repo_location value

[Mark T. Voelker]

Some time back the puppet-coe module changed how it sets repository URL's in order to allow users to set the pocket they want to use (e.g. folks can use snapshot repositories or the -proposed pocket if they want to live on the edge). When that was done, code was also added to detect the old URL format and automatically adjust it to the new expected format--and emit a warning when it does so in order to let the user know that the setting should be updated:

https://github.com/CiscoSystems/puppet-coe/blob/h.2/manifests/base.pp#L68-L80

A corresponding change was made to puppet_openstack_builder in the hiera_data/vendor/cisco_coi_common.yaml file as well so that users wouldn't see the warning:

https://github.com/stackforge/puppet_openstack_builder/commit/ebfc0a2801f63982ecc83883f8f1885da5692fd4

However, that parameter is also set in HA scenarios in hiera_data/enable_ha/true.yaml:

https://github.com/stackforge/puppet_openstack_builder/blob/master/data/hiera_data/enable_ha/true.yaml#L13

That file was never updated, so users of the HA scenarios will see the warning emitted.

[Mark T. Voelker (mvoelker)]

Master patch for Icehouse:
https://review.openstack.org/80362

[Mark T. Voelker (mvoelker)]

Patch for stable/havana:
https://review.openstack.org/#/c/81171/