BigSwitch: should call eventlet sleep in watchdog

Bug #1291695 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Kevin Benton

Bug Description

The consistency watchdog in eventlet currently calls time.sleep which will block other greenthreads who are members of the same pool.

https://github.com/openstack/neutron/blob/288e3127440158f177beaae1972236def4916251/neutron/plugins/bigswitch/servermanager.py#L554

It should use eventlet.sleep so it yields to other members of the same pool.

Tags: bigswitch
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
tags: added: bigswitch
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80130

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/80130
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=402175a787c2064404eaf7c260a16ea05e9a99a3
Submitter: Jenkins
Branch: master

commit 402175a787c2064404eaf7c260a16ea05e9a99a3
Author: Kevin Benton <email address hidden>
Date: Wed Mar 12 17:47:28 2014 -0700

    BigSwitch: Use eventlet.sleep in watchdog

    Changes the consistency watchdog that runs
    in the background to use eventlet.sleep instead
    of time.sleep to avoid blocking other members of
    the same pool.

    Closes-Bug: #1291695
    Change-Id: I5ec842cca1063cef761c2cd09d63617baf27d191

Changed in neutron:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in neutron:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.