Remove compatibility wares
Bug #1291554 reported by
Hans Joachim Desserud
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
Hans Joachim Desserud | ||
Bug Description
When starting a new game the following message is printed to the terminal:
Compatibility ware "flax"="thatchreed" loaded.
This is no longer needed as we are currently removing compatibility workarounds for older save games.
I've started removing these sections from the code base. I haven't yet decided, but I will probably remove the code for loading/replacing the wares too. I haven't looked at how complex the framework is and whether we would like to keep it for future use, but the earliest time we'll have a use for it would be the release of build20. So unless we wish to keep it around, I will probably remove it all together.
Related branches
lp:~widelands-dev/widelands/remove-compatibility-wares
- SirVer: Approve
-
Diff: 680 lines (+12/-327)20 files modifiedsrc/economy/ware_instance.cc (+0/-19)
src/logic/immovable.cc (+11/-29)
src/logic/instances.cc (+1/-20)
src/logic/instances.h (+0/-7)
src/logic/productionsite.cc (+0/-36)
src/logic/productionsite.h (+0/-13)
src/logic/tribe.cc (+0/-46)
src/logic/tribe.h (+0/-11)
src/logic/widelands_streamread.cc (+0/-3)
src/logic/worker.cc (+0/-21)
src/logic/worker.h (+0/-2)
src/logic/worker_descr.cc (+0/-20)
src/logic/worker_descr.h (+0/-10)
src/map_io/widelands_map_buildingdata_data_packet.cc (+0/-57)
tribes/barbarians/battlearena/conf (+0/-3)
tribes/barbarians/conf (+0/-11)
tribes/barbarians/ferner/conf (+0/-5)
tribes/barbarians/fernery/conf (+0/-8)
tribes/barbarians/metalworks/conf (+0/-3)
tribes/empire/sawmill/conf (+0/-3)
| Changed in widelands: | |
| status: | Triaged → In Progress |
Revision history for this message
| SirVer (sirver) wrote | #1 |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #2 |
To post a comment you must log in.
I think you can remove the one ware and the whole framework. If we ever need it again, it is one commit that needs to be rolled back, but that should be easy to do. It is not sensical to maintain code that is not used.