verbose_name is unnecessary for hidden field

Bug #1291548 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

verbose_name is unnecessary for hidden field.
Some verbose_name does not have much meaning (it is just a mirror of form field name) but it is marked as translated and such strings are difficult to translate. One I encountered is in openstack_dashboard/dashboards/project/containers/tables.py.

    metadata_loaded = tables.Column(get_metadata_loaded,
                                    verbose_name=_("Metadata Loaded"),
                                    status=True,
                                    status_choices=METADATA_LOADED_CHOICES,
                                    hidden=True)

metadata_loaded is difficult to translate and there is no need to translate it too because it is invisible in a browser.

I would suggest to delete verbose_name from hidden field.
According to my check, we have only four hidden fields with verbose_name.
it can be easy to clean up.

Tags: i18n
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80196

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/80196
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3301ce762ae608e5c005e5f4c076288c67ed7630
Submitter: Jenkins
Branch: master

commit 3301ce762ae608e5c005e5f4c076288c67ed7630
Author: Akihiro Motoki <email address hidden>
Date: Thu Mar 13 03:36:34 2014 +0900

    Remove verbose_name from hidden fields

    verbose_name is unnecessary for hidden field.
    Some verbose_name does not have much meaning
    (it is just a mirror of form field name), but
    it is marked as translated and such strings
    are difficult to translate. To address this,
    this commit cleans up verbose_name of hidden fields.

    Change-Id: I14fc242f90ce22abe5a0517b44968c2a98f97f48
    Closes-Bug: #1291548

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.