Incorrect backup/restore tests trying to execute their cmd on the real jenkins slave environment

[Denis M.]

http://logs.openstack.org/60/77160/5/check/gate-trove-python27/199b1e7/console.html

2014-03-12 15:29:20.085 | > Mar 12 15:29:08 bare-precise-hpcloud-az2-2631790 sudo: jenkins : 3 incorrect password attempts ; TTY=unknown ; PWD=/home/jenkins/workspace/gate-trove-python27 ; USER=root ; COMMAND=innobackupex --stream=xbstream --incremental --incremental-lsn=54321 /var/lib/mysql
2014-03-12 15:29:20.122 | + sudoresult=1
2014-03-12 15:29:20.123 | + '[' 1 -ne 0 ']'
2014-03-12 15:29:20.123 | + echo
2014-03-12 15:29:20.123 |
2014-03-12 15:29:20.123 | + echo 'This test has failed because it attempted to execute commands'
2014-03-12 15:29:20.123 | This test has failed because it attempted to execute commands
2014-03-12 15:29:20.123 | + echo 'with sudo. See above for the exact commands used.'
2014-03-12 15:29:20.124 | with sudo. See above for the exact commands used.
2014-03-12 15:29:20.124 | + echo
2014-03-12 15:29:20.124 |

Given test (below) breaks the gate
https://github.com/openstack/trove/blob/master/trove/tests/unittests/guestagent/test_backups.py#L106-L114

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/81142

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/81142
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=19d940516ecb0d7d6621f09be3f76dc1b5c482b5
Submitter: Jenkins
Branch: master

commit 19d940516ecb0d7d6621f09be3f76dc1b5c482b5
Author: Nikhil Manchanda <email address hidden>
Date: Mon Mar 17 19:20:08 2014 -0700

    Fixed unit test to not actually run backup command

    One unit tests is still trying to execute the actual backup command
    instead of the mocked backup command. This is causing an issue on
    the Jenkins slave where it is trying to run as sudo (and failing).
    Fixed the test to use a mock runner, and not try to run innobackupex.

    Change-Id: Ifff7945be158a08167cdd282ed8eb18952224eee
    Closes-bug: 1291516

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/84627

[Denis M. (dmakogon)]

Bug still appears

[Denis M. (dmakogon)]

Proposed fix doesn't kill the actual proplem, bug still appears, http://logs.openstack.org/68/83768/16/check/gate-trove-python27/5df6209/console.html#_2014-04-02_04_23_53_035

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84627
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=0e9dd94eb0622662d1b91eb05f14cb4706f2cecf
Submitter: Jenkins
Branch: master

commit 0e9dd94eb0622662d1b91eb05f14cb4706f2cecf
Author: Nikhil Manchanda <email address hidden>
Date: Tue Apr 1 22:31:16 2014 -0700

    Fixed unit test to not actually run backup command

    One unit tests is still trying to execute the actual backup command
    instead of the mocked backup command. This is causing an issue on
    the Jenkins slave where it is trying to run as sudo (and failing).
    Fixed the test to use a mock runner, and not try to run innobackupex.

    This had been previously fixed by commit 19d940516e, but that fix was
    clobbered by the move from mockito to mock.

    Change-Id: Ib63187d4414a3ef7b7f664e076bb4d92a40c2214
    Closes-bug: 1291516