conductor logs expected exceptions

Bug #1291509 reported by aeva black
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
David Shrewsbury

Bug Description

RPC methods may return an exception from the ConductorManager as an expected means to inform the API of an error. Such expected exceptions should not be logged within the conductor -- otherwise the log will be meaningless as real (unexpected) exceptions go unnoticed.

aeva black (tenbrae)
Changed in ironic:
status: New → Triaged
importance: Undecided → High
milestone: none → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/80022

Changed in ironic:
assignee: nobody → Devananda van der Veen (devananda)
status: Triaged → In Progress
Changed in ironic:
assignee: Devananda van der Veen (devananda) → David Shrewsbury (dshrews)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/80022
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=fc490d490ac7704c4654395fb21d498b9f1c7f4e
Submitter: Jenkins
Branch: master

commit fc490d490ac7704c4654395fb21d498b9f1c7f4e
Author: Devananda van der Veen <email address hidden>
Date: Wed Mar 12 10:40:03 2014 -0700

    Suppress conductor logging of expected exceptions

    RPC methods may return an exception from the ConductorManager as an
    expected means to inform the API of an error. Such expected exceptions
    should not be logged within the conductor -- otherwise the log will be
    overflowing and real (unexpected) exceptions will go unnoticed.

    This patch adds a decorator to the RPC methods in ConductorManager to
    suppress logging of expected exceptions, while still passing them back
    to the API.

    Co-Authored-By: David Shrewsbury <email address hidden>

    Change-Id: Ic3107a9af6afeb2a9e772ca0ce0acc45dbc182cb
    Closes-bug: #1291509

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.