migrate 1.16 agent config to 1.18 properly (DataDir, Jobs, LogDir)
Bug #1291400 reported by
Dimiter Naydenov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
Critical
|
Dimiter Naydenov |
Bug Description
We need tests that multiple upgrades from 1.16 to 1.18 and above work, as mentioned in bug 1290684.
The reason for the failure is that when reading a 1.16 agent config some values were not set before writing the migrated 1.18 agent config: DataDir (now required; it's either /var/lib/juju or $JUJU_HOME/local for the local provider), LogDir (optional; should default to /var/log/juju, except for the local provider), Jobs (optional, but we need to add them appropriately: JobHostUnits for all machines, except the bootstrap node; and JobManageEnviro
Related branches
lp:~dimitern/juju-core/340-lp-1291400-1.16-to-1.18-agent-config-migration
- Juju Engineering: Pending requested
-
Diff: 1050 lines (+638/-69)16 files modifiedagent/agent.go (+86/-18)
agent/agent_test.go (+133/-12)
agent/export_test.go (+40/-0)
cmd/jujud/machine.go (+4/-4)
provider/manual/environ.go (+3/-6)
upgrades/agentconfig.go (+150/-0)
upgrades/agentconfig_test.go (+178/-0)
upgrades/deprecatedenvsettings.go (+1/-1)
upgrades/deprecatedenvsettings_test.go (+11/-11)
upgrades/export_test.go (+7/-1)
upgrades/steps118.go (+8/-3)
upgrades/steps118_test.go (+2/-1)
upgrades/upgrade.go (+1/-1)
upgrades/upgrade_test.go (+10/-9)
utils/file_unix.go (+3/-2)
worker/rsyslog/worker.go (+1/-0)
Changed in juju-core: | |
assignee: | nobody → Dimiter Naydenov (dimitern) |
tags: | added: upgrade-juju |
Changed in juju-core: | |
importance: | High → Critical |
Changed in juju-core: | |
milestone: | 1.17.5 → 1.18.0 |
Changed in juju-core: | |
milestone: | 1.18.0 → 1.17.6 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.