[Validation] EDP allows creating Job Execution w/ INPUT and OUTPUT to the same URI

[Alexander Ignatov]

Steps to reproduce:

1. Create INPUT data source and OUTPUT data source where:
INPUT=OUTPUT=swift://some_path/object

2. Run Job using previously created input and output.

Result:
Job turns to the KILLED state with the following error in the log:

http://paste.openstack.org/show/73245/

Solution:

This could be prevented in the validation level during creation job execution. Just do not allow select the same locations for INPUT, OUTPUT for jobs.

[Andrew Lazarev (alazarev)]

Attached stacktrace points to more general problem. Sahara could check that
1. Input source exists
2. Output source doesn't exist

Validation that input!=output doesn't make much sense for me.

[Dmitry Mescheryakov (dmitrymex)]

Andrew, I agree that the fix you propose is better. But as far as I understand, it will be _much_ more complex then just comparing types and urls of input and output. We don't want to introduce big changes at that point. On the other hand, the later approach gives at least some validation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/82910

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/82910
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=a08857dc89fd08df55db4f4355c9917ba7a20278
Submitter: Jenkins
Branch: master

commit a08857dc89fd08df55db4f4355c9917ba7a20278
Author: Dmitry Mescheryakov <email address hidden>
Date: Wed Mar 26 00:12:28 2014 +0400

    Validate data sources reference different resources

    The proposed fix compares input and output data sources. If they
    have the same types and urls, a validation error is thrown.

    Closes-bug: #1291380

    Change-Id: I09956c2e29c1e12d9e5c28a5c7953f97197b3565