Settings nav method can call attempt access of slug on None

Bug #1291050 reported by David Lyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
David Lyle

Bug Description

When adding tests to horizon, it's possible to encounter an error in dashboards/settings/dashboard.py where the current dashboard is not set. Then the slug attribute is attempted to be accessed on None. Doesn't work real well :)

David Lyle (david-lyle)
Changed in horizon:
milestone: none → icehouse-rc1
importance: Undecided → Low
assignee: nobody → David Lyle (david-lyle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79769

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/79769
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ab3cdfd1c90039a126f8310c3d57847bf95542ea
Submitter: Jenkins
Branch: master

commit ab3cdfd1c90039a126f8310c3d57847bf95542ea
Author: David Lyle <email address hidden>
Date: Tue Mar 11 15:04:52 2014 -0600

    Fixing potential attribute access on None

    Specifically when writing tests, the nav method in the settings
    dashboard.py file can potentially attempt to access slug on None.

    Closes-bug: #1291050

    Change-Id: I6df58d26f5df71ac7c605c5d77b9aa9d8d811956

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.