Availability zones v2 is not tested and used correctly

Bug #1290956 reported by Eugeniya Kudryashova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Eugeniya Kudryashova

Bug Description

Availability zones v1 and v2 duplicate each other. Tests for v2 zones actually duplicates tests for v1 zones (in import statemens also[1]), so v2 zones is not actually tested.

Availability zones v2 is not used in v2 client[2], this module have only one usage in shell v2[3]. This usage doesn't seems correct. We obtain zone using manager v1[4](because both v1 and v2 clients use v1 availability zones manager), but try to process it using v2 manager[5], this works only because this managers are equal.

[1]https://github.com/openstack/python-cinderclient/blob/474c9ee58b7874a198a679c0e76328e659718e34/cinderclient/tests/v2/test_availability_zone.py#L19
[2]https://github.com/openstack/python-cinderclient/blob/474c9ee58b7874a198a679c0e76328e659718e34/cinderclient/v2/client.py#L17
[3]https://github.com/openstack/python-cinderclient/blob/474c9ee58b7874a198a679c0e76328e659718e34/cinderclient/v2/shell.py#L28
[4]https://github.com/openstack/python-cinderclient/blob/474c9ee58b7874a198a679c0e76328e659718e34/cinderclient/v2/shell.py#L1002
[5]https://github.com/openstack/python-cinderclient/blob/474c9ee58b7874a198a679c0e76328e659718e34/cinderclient/v2/shell.py#L958

Changed in python-cinderclient:
assignee: nobody → Eugeniya Kudryashova (ekudryashova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79703

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/79703
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=e18baa0c516b74091d6a21552f352316bfe9a7b5
Submitter: Jenkins
Branch: master

commit e18baa0c516b74091d6a21552f352316bfe9a7b5
Author: ekudryashova <email address hidden>
Date: Tue Mar 11 18:29:13 2014 +0200

    Fix usage of v1 and v2 availability zones

    Change usage of availability zones in client. V2 client should
    use appropriate version of manager of availability zones.

    Also change tests of v2 availability zones to test version 2
    instead of one more time test v1 availability zones.

    Change-Id: Iec3863a105a20f876a303f789cc1edfafa58f4df
    Closes-Bug: #1290956

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.