[astute] socket.shutdown fails when nothing connected

Bug #1290741 reported by Andrey Danin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Low
Vladimir Sharshov

Bug Description

4.1
Problem is here: https://github.com/stackforge/fuel-astute/blob/master/mcagents/net_probe.rb#L121
When timeout in line 110 has occured there is no client connected and socket.shutdown raises "Errno::ENOTCONN: Transport endpoint is not connected".
Maybe we should move socket.shutdown into Timeout clause or get git of it totally. And socket.close must be called only if socket is established.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79872

Changed in fuel:
assignee: nobody → Vladimir Sharshov (vsharshov)
status: New → In Progress
Changed in fuel:
milestone: none → 4.1.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (master)

Reviewed: https://review.openstack.org/79872
Committed: https://git.openstack.org/cgit/stackforge/fuel-astute/commit/?id=33654506a9934a5f28f02e79b99dda79040b2ac3
Submitter: Jenkins
Branch: master

commit 33654506a9934a5f28f02e79b99dda79040b2ac3
Author: Vladimir Sharshov <email address hidden>
Date: Wed Mar 12 10:59:49 2014 +0400

    Prevent to raise Errno::ENOTCONN if no client connected

    Small refactoring

    Change-Id: I500e3e30b5678b5ce126573cb3e2b360a490b155
    Closes-Bug: #1290741

Changed in fuel:
status: In Progress → Fix Committed
tags: added: inprogress
Revision history for this message
Anastasia Palkina (apalkina) wrote : Re: socket.shutdown fails when nothing connected

Verified on ISO #266
"build_id": "2014-04-03_04-17-26",
"mirantis": "yes",
"build_number": "266",
"nailgun_sha": "7a05e365240ab27c492b20585ef8ac8557102cc0",
"ostf_sha": "de0222fed646525d248dc6892eeceab139d5c469",
"fuelmain_sha": "16637e2ea0ae6fe9a773aceb9d76c6e3a75f6c3b",
"astute_sha": "5bcacc84cdaee3b31f1178d92a1c0681dc6ce520",
"release": "4.1",
"fuellib_sha": "52e7f57695f33bafa5d84d524d77f1bc3a2289b2"

Andrey Danin should add comment why verification has failed

Changed in fuel:
status: Fix Committed → Triaged
Revision history for this message
Anastasia Palkina (apalkina) wrote :

1) Global timeout triggered for environment, not those in fix
2) Need to kill listeners on all of nodes

Changed in fuel:
milestone: 4.1.1 → 5.1
Changed in fuel:
importance: Medium → Low
Dmitry Ilyin (idv1985)
summary: - socket.shutdown fails when nothing connected
+ [astute] socket.shutdown fails when nothing connected
Changed in fuel:
milestone: 5.1 → 6.0
Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Does this bug still actual? As i know this part of code was updated several times.

Changed in fuel:
milestone: 6.0 → 6.1
Dmitry Pyzhov (dpyzhov)
tags: added: module-astute
removed: astute inprogress mcagent
Changed in fuel:
milestone: 6.1 → 7.0
Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Looks like it does not actual anymore. As i know, we have plan to big refactoring of net check part. Move it to 7.0

Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

Mark it as Invalid. Last report about problem was more that 1 year ago. Feel free to reopen it if it still affect release.

Changed in fuel:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.