webui: need to set a mimetype for subunit stream file

Bug #1290732 reported by Evan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu CI Engine
Fix Released
Medium
Andy Doan
Ubuntu CI Services
Fix Released
Medium
Andy Doan

Bug Description

Clicking on test_runner.python-scipy-subunit-stream for a ticket triggers a download. However, all the other files are displayed in the browser as text and the subunit stream should be no different.

Tags: airline
Revision history for this message
Vincent Ladeuil (vila) wrote :

The test runner doesn't specify the mime type for the stream, feel free to bounce that bug to me if that's the root cause.

Note that, in the long run, we'll use the subunit v2 format which is binary though.

Revision history for this message
Chris Johnston (cjohnston) wrote : Re: [Bug 1290732] Re: webui: need to set a mimetype for subunit stream file

Based on the comment from vila on bug #1290401 and the discussions we had
yesterday, I would think we would want these files to be downloaded so that
the user can run subunit-1to2 ~/Downloads/autopkgtest-subunit-stream |
subunit2junitxml
on it

Revision history for this message
Andy Doan (doanac) wrote :

Even though we want them to download, since its plain text its really easy to make this viewable in the browser:

http://bazaar.launchpad.net/~canonical-ci-engineering/ubuntu-ci-services-itself/trunk/view/head:/test_runner/tstrun/run_worker.py#L68

            subunit_url = store.put_file(artifact_name,
                                         subunit_stream)

Just add 'text/plain' as the last parameter, ie:

            subunit_url = store.put_file(artifact_name,
                                         subunit_stream, 'text/plain')

Andy Doan (doanac)
Changed in ubuntu-ci-services-itself:
status: New → Fix Released
Changed in ubuntu-ci-services-itself:
milestone: backlog → phase-0
Vincent Ladeuil (vila)
Changed in ubuntu-ci-services-itself:
assignee: nobody → Andy Doan (doanac)
importance: Undecided → Medium
Ursula Junque (ursinha)
Changed in uci-engine:
assignee: nobody → Andy Doan (doanac)
importance: Undecided → Medium
milestone: none → phase-0
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.