Traceback "ERROR" from a normal server create failure seen at default log level

[Clint Byrum]

Things failing is a normal condition, and we don't need those at the default log level:

2014-03-10 15:27:34.670 2815 ERROR heat.engine.resource [-] CREATE : Server "NovaCompute0" [013ab31b-3b74-4572-86b9-28b9b1439f64] Stack "overcloud" [e14bf867-0e89-4025-b838-3e3501bfe0ae]
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource Traceback (most recent call last):
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource File "/opt/stack/venvs/heat/local/lib/python2.7/site-packages/heat/engine/resource.py", line 420, in _do_action
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource while not check(handle_data):
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource File "/opt/stack/venvs/heat/lib/python2.7/site-packages/heat/engine/resources/server.py", line 529, in check_create_complete
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource return self._check_active(server)
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource File "/opt/stack/venvs/heat/lib/python2.7/site-packages/heat/engine/resources/server.py", line 545, in _check_active
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource raise exc
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource Error: Creation of server overcloud-NovaCompute0-kzd5xqep3glj failed.
2014-03-10 15:27:34.670 2815 TRACE heat.engine.resource

This is logged as an ERROR, but it is really an INFO level message.

[Thomas Herve (therve)]

It's because of the oslo.message work. The exception decorator has been removed from the Engine methods, but they should be unnecessary soon.

[Rakesh H S (rh-s)]

Hi Clint,

Are you saying that since error is one of the permissible state, the orchestration engine should show it as an info level?
i.e for ex: if creation of server failed at Nova, and the server is in one of the permissible state (i.e Error), we would consider this as info?

if yes, then are you saying when an exception is raised, it is not get practice to use logging.exception(...)?

Regards,
Rakesh

[Rakesh H S (rh-s)]

correcting typo:
get -> good

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/107551

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107551
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=becbc26527755a1552528d9a041d3fdc2446494e
Submitter: Jenkins
Branch: master

commit becbc26527755a1552528d9a041d3fdc2446494e
Author: Rakesh H S <email address hidden>
Date: Thu Jul 17 08:41:27 2014 +0530

    Fixed resource errors logged at default log level

    * Heat was logging resource failures traceback at default log level.

    * Resources failing is a normal condition, and once a resource has failed,
    heat has already reached one of the permissible state ex: CREATE_FAILED,
    hence heat should not log the resource failures traceback in default log
    level.

    * Have made necessary changes to log resource failures traceback at INFO
    level.

    Change-Id: Ica27cac5a94734c2db08cee2e7fe31289169fec9
    Closes-Bug: #1290565