neutron_admin_tenant_name deprecation warning is wrong

[Robert Collins]

ARNING nova.network.neutronv2 [req-eb54925d-c466-4069-be4e-691e155ea85d None None] Using neutron_admin_tenant_name for authentication is deprecated and will be removed in the next release. Use neutron_admin_tenant_id instead.

[Robert Collins (lifeless)]

This seems like a usability regression, because 'name=service' was trivial to look at and reason about. 'id=$uuid' is much worse.

[Robert Collins (lifeless)]

(This also introduces a circular dependency on deployments, which is terrible).

[Robert Collins (lifeless)]

commit e80cf75fc0f25f6279200f59a70fd7c6e4766b0f
Author: Phil Day <email address hidden>
Date: Wed Jan 29 20:48:49 2014 +0000

    Add support for tenant_id based authentication with Neutron

    Keystone v3 supports non-unique project/tenant names, so
    Nova should switch to using tenant ID for admin authentication.

    Implements blueprint tenant-id-based-auth-for-neutron
    DocImpact: Adds new flag, nova_admin_tenant_id, and deprecates
    existing flag, nova_admin_tenant_name

    Change-Id: I4a4ffe84fdcf98ace81fd148f096cad483aad96c

[Joe Gordon (jogo)]

commit e80cf75fc0f25f6279200f59a70fd7c6e4766b0f
Author: Phil Day <email address hidden>
Date: Wed Jan 29 20:48:49 2014 +0000

    Add support for tenant_id based authentication with Neutron

    Keystone v3 supports non-unique project/tenant names, so
    Nova should switch to using tenant ID for admin authentication.

    Implements blueprint tenant-id-based-auth-for-neutron
    DocImpact: Adds new flag, nova_admin_tenant_id, and deprecates
    existing flag, nova_admin_tenant_name

    Change-Id: I4a4ffe84fdcf98ace81fd148f096cad483aad96c

[Matt Riedemann (mriedem)]

nova patch: https://review.openstack.org/#/c/79470/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/79470
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6a36d367b54538ef6347c948b3e549f21993771a
Submitter: Jenkins
Branch: master

commit 6a36d367b54538ef6347c948b3e549f21993771a
Author: Robert Collins <email address hidden>
Date: Tue Mar 11 11:00:47 2014 +1300

    Revert deprecation warning on Neutron auth.

    This reverts the deprecation warning added in commit
    e80cf75fc0f25f6279200f59a70fd7c6e4766b0f.

    V3 supports domain + project uniqueness, which is much more usable
    than ids - massively more so for deployers. The initial patch
    deprecates name, when that isn't necessary or appropriate - using name
    based auth is as valid as id based auth - we just need to namespace
    it in V3.

    For V3 operators should be able to create:

    * A service domain
    * A service/service project
    * A service/neutron user

    to replace the prior

    * service tenant
    * neutron user

    structure without switching to ids.

    Closes-Bug: #1290540
    Change-Id: I51837b0dc1bc352c0bf315e383951486b3cac034