minimized construction window gets maximized when construction ends

[Flávio J. Saraiva]

Not sure if this is intended behavior, this is a follow up to comment 2 of bug #1289943.

A minimized construction window will get automatically maximized when construction ends.

Steps to reproduce:
- start a game
- place a building
- click on building to open the construction window
- CTRL+click on the title to minimize it
- wait for construction to end
- you'll see the window get maximized

Expected behaviour:
Minimized windows stays minimized.

[Hans Joachim Desserud (hjd)]

I believe this is a (un)intended consequence of bug 1132238. The old behaviour was that any construction site building you had open would be closed once the building was finished because there was no link between the construction site and the finished building. Thus, in order to adjust the settings you would have to look up the building again and reopen the window in order to do so.

However, it looks like the implementation doesn't take into consideration whether the construction site window was minimized (probably an edge case which wasn't considered at the time). It would be nice if it could remember the current state of the construction window when replacing it with a building window.

[SirVer (sirver)]

Setting to incomplete for bug sweeping.

[Hans Joachim Desserud (hjd)]

We should probably decide what the expected behaviour is here. Re-reading this now, it sounds more like a useful feature than a bug to me.

If I open a construction site window and minimizes it, it's probably because I want to keep track of it and do something once it has finished. For instance I want to adjust the amount of wares or immediately upgrade a barbarian metalworks to an axfactory. In this case I get a notification that construction has finished, rather than having to un-/reminimizing the window from time to time to check manually.

We should probably discuss other possible use cases before deciding whether this should be fixed.

[GunChleoc (gunchleoc)]

I have never used the minimizing feature, but it does sound useful to me that it will pop up when construction has finished for the reasons you stated.

[Flávio J. Saraiva (flaviojs2005)]

In general, I minimize windows so I can focus on another task without being interrupted (auto maximizing disrupts what I'm doing).

Buildings under construction have the name inside parenthesis and there's also the building statistics text so I don't need to open the window to check if it's done, I just look at the title. (it also changes width when done)
On some cases I temporarily restore it to estimate how long it will take or to see if it's stuck on a particular resource.

I keep related minimized windows stacked on top of each other.
It's risky to use a window if it has a minimized construction window above it.
A few times I clicked a button in the wrong window because another one auto maximized on top of it.
This forces me to wait until everything above the window is finished or move the window before safely interacting with it.

I also keep a minimized window for each area I'm keeping an eye on/expanding/fighting for; In the expanding case the building is probably still under construction and the target building keeps changing.
I restore, click to center view, and minimize the window again whenever I want to check out the area.

[SirVer (sirver)]

#5 seems like a very good use case and argument for not maximizing the window. It comes down to preference of polling or being pushed. I think we should not decide that for the user and therefore not maximize a window she minimized explicitly before.

[GunChleoc (gunchleoc)]

Let's keep these minimized then. +1

[Hans Joachim Desserud (hjd)]

Yes, plenty of good points in #5. Let's go for that.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1