Test refresh_instance_security_rules in nova.tests.virt.test_virt_drivers

Bug #1290036 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Matt Riedemann

Bug Description

Change https://review.openstack.org/#/c/69600/ adds a new method refresh_instance_security_rules to the nova ComputeDriver interface but it missed adding a test to nova.tests.virt.test_virt_driver to make sure all virt drivers are explicitly handling it.

There is also a typo in the method's docstring.

Tags: testing
Matt Riedemann (mriedem)
Changed in nova:
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79195

Changed in nova:
status: Triaged → In Progress
Changed in nova:
importance: Undecided → Wishlist
Revision history for this message
Matt Riedemann (mriedem) wrote :

This is not a wishlist item, it's a bug to not have test coverage for the virt driver API in test_virt_drivers.

Changed in nova:
importance: Wishlist → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/79195
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=100c42ed15be5fc3ca52fb7cba0987e768a18a3f
Submitter: Jenkins
Branch: master

commit 100c42ed15be5fc3ca52fb7cba0987e768a18a3f
Author: Matt Riedemann <email address hidden>
Date: Sun Mar 9 08:52:05 2014 -0700

    Fix typo and add test for refresh_instance_security_rules

    Change Ia36b0dfb adds virt driver API method
    refresh_instance_security_rules but there is a typo in the method's
    docstring and it needs to be covered in test_virt_drivers.py.

    Closes-Bug: #1290036

    Change-Id: Idacffe2087f0bec6290e3422d1e777376b489615

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.