Several UnicodeDecodeError when running in/for directories containing non-ASCII chars

[alanjeremy]

i cannot download any subtitles at all
the download button is grey and does not function
the log button is also grey and does not work
i tried to uninstall and reinstall; but that did not work
i made sure that port 8080 is open in my firewall
i use ubuntu 12.04 lts
if i ask for subtitles for a video file i have, i may get a list but cannot download any
if i give a movie name and ask for subtitles, i may get a list but cannot download anything

[alanjeremy (deaton25)]

also, now my Search button for Search by Movie Name does not work!!!!!

[alanjeremy (deaton25)]

my SUBDOWNLOADER is not downloading subtitles! It is not working!
If i click on a movie that i have already downloaded (first tab), a list of subtitles is compiled but the Download button will not work.
If i search for subtitles for a movie that i input into the search bar (second tab), a list is compiled.But the Download button does not work and no subtitles are downloaded.

PLEASE HELP

[Launchpad Janitor (janitor)]

[Expired for SubDownloader because there has been no activity for 60 days.]

[ds9 (stephane-lentz)]

Subdownloader cannot save subtitles in directories non-ascii names : names which includes accents for instance : ~/Téléchargements

subdownloader will report when launched in cli :

Traceback (most recent call last):
  File "/usr/share/subdownloader/gui/main.py", line 1054, in onButtonDownload
    _("%s cannot be saved.\nCheck that the folder exists and you have write-access permissions.") %destinationPath ,
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 16: ordinal not in range(128)

[ds9 (stephane-lentz)]

Debug information :
[23:29] DEBUG::subdownloader.gui.videotreeview # setVideos-> len(videoResults) = 1
[23:29] DEBUG::subdownloader.gui.main # Downloading to: '/home/stephane/T\xc3\xa9l\xc3\xa9chargements/Arrow S02E20 HDTV XviD-FUM[ettv]/Arrow.S02E20.HDTV.XviD-FUM.srt'
[23:29] DEBUG::subdownloader.gui.main # Trying to download subtitle '/home/stephane/Téléchargements/Arrow S02E20 HDTV XviD-FUM[ettv]/Arrow.S02E20.HDTV.XviD-FUM.srt'
Traceback (most recent call last):
  File "/usr/share/subdownloader/gui/main.py", line 1054, in onButtonDownload
    _("%s cannot be saved.\nCheck that the folder exists and you have write-access permissions.") %destinationPath ,
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 16: ordinal not in range(128)

[Benek (beniamin.kalinowski)]

This is the problem with VideoFile object. It's _filepath attribute is one time encoded as a 'str' and other time as 'unicode'.

The fix:
in source: FileManagement/FileScan.py:

 def ScanFolder(folderpath, recursively=True, report_progress=None, progress_end=None):
+ if (type(folderpath) is not str):
+ folderpath = folderpath.encode(sys.getfilesystemencoding())
     # Let's reset the progress bar to 0%
     log.debug("Scanning Folder %s" % folderpath)

in source modules/videofile.py:

=== modified file 'modules/videofile.py'
--- modules/videofile.py 2011-02-13 09:15:02 +0000
+++ modules/videofile.py 2014-06-01 14:33:54 +0000
@@ -25,6 +25,9 @@

     def __init__(self, filepath):
         self._filepath = filepath
+ if (type(filepath) is not str):
+ import sys
+ self._filepath = filepath.encode(sys.getfilesystemencoding())
         self._size = os.path.getsize(filepath)
         self._hash = self.calculateOSDBHash()
         try:

[Mattia Rizzolo (mapreri)]

This was fixed in 2.0.18-2.1 (as available in bionic), but then the change was reverted in 2.0.19-1 (in cosmic).

This is again fixed in the next upstream 2.1.0~rc4 that I'm preparing. I don't know if I'll get around to it in time for disco.

[Launchpad Janitor (janitor)]

This bug was fixed in the package subdownloader - 2.1.0~rc4-2

---------------
subdownloader (2.1.0~rc4-2) unstable; urgency=medium

  * Team upload.
  * Upload to unstable
  * debian/control
    - bump Standards-Version to 4.4.0 (no changes needed)

 -- Sandro Tosi <email address hidden> Wed, 21 Aug 2019 16:42:22 -0400