Chase improper ValueErrors
Bug #1289761 reported by
Georges Racinet
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenERP buildout recipe |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Because I did not know better at that time, the code raises ValueError in many places, whereas zc.buildout has a dedicated exception, UserError, to properly signal errors in configuration.
Actually zc.buildout somehow insists that we use its exception :
not raising UserError leads to the infamous "an error occurred either in zc.buildout or a recipe", making people think the recipe does not work, and that's discouraging for newcomers.
There are enough possibilities of true failure already : network problems, launchpad stability, PyPI infrastructure (got very much better with CDN and policy to avoid DDOS-ing irrelevant project websites).
Related branches
Revision history for this message
| Georges Racinet (gracinet) wrote | #1 |
| Changed in anybox.recipe.openerp: | |
| milestone: | none → 1.8.3 |
Revision history for this message
| Georges Racinet (gracinet) wrote | #2 |
| Changed in anybox.recipe.openerp: | |
| status: | New → In Progress |
| Changed in anybox.recipe.openerp: | |
| status: | In Progress → Fix Committed |
| Changed in anybox.recipe.openerp: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Of course this should go in the stable branch