Templates used in CFN template unit tests are not complete

Bug #1289487 reported by Jason Dunsmore
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Sergey Kraynev

Bug Description

The template version is a required field in a template. However, many of the templates used in the CFN template unit tests do not include the template version. Instead, they rely on Heat providing a default template version. This logic needs to be removed from Heat and the unit tests need to be modified to use valid templates.

For reference, see conversation here:
https://review.openstack.org/#/c/77755/3/heat/engine/template.py

Revision history for this message
Jason Dunsmore (jasondunsmore) wrote :

The logic to provide a default template version for HOT templates also needs to be removed.

Changed in heat:
assignee: nobody → Jason Dunsmore (jasondunsmore)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79770

Changed in heat:
status: New → In Progress
Changed in heat:
assignee: Jason Dunsmore (jasondunsmore) → Sergey Kraynev (skraynev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/83380
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6799a8b12aa57df3925ec908ba81dd2e31a5f78a
Submitter: Jenkins
Branch: master

commit 6799a8b12aa57df3925ec908ba81dd2e31a5f78a
Author: Sergey Kraynev <email address hidden>
Date: Thu Mar 27 09:30:24 2014 -0400

    Removing default version for templates

    There are a lot of places in unittests where defined template
    does not contain template version. This section should be added
    everywhere. At this moment if template has not version field,
    exception should be raised.

    Closes-Bug: #1289487
    Change-Id: I422b1468bfd57880fda0dac15ad53932fce7a447

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → juno-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.