Fake test logger didn't appointed to an instance attribute.

Bug #1289403 reported by Ilya Pekelny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Medium
Ilya Pekelny

Bug Description

Fake logger didn't appointed to an instance attribute https://github.com/openstack/oslo.test/blob/master/oslotest/base.py#L64 .

From FakeLogger docstring follows:

     test_log(self)
          fixture = self.useFixture(LoggerFixture())
          logging.info('message')
          self.assertEqual('message', fixture.output)

A fake logger instance has a property `output` which must be accessible from BaseTestCase subclasses instances.

Ilya Pekelny (i159)
Changed in oslo:
assignee: nobody → Ilya Pekelny (i159)
status: New → In Progress
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.test (master)

Reviewed: https://review.openstack.org/78993
Committed: https://git.openstack.org/cgit/openstack/oslo.test/commit/?id=7d06dac0c0fba493c62274557215ac339a1e9093
Submitter: Jenkins
Branch: master

commit 7d06dac0c0fba493c62274557215ac339a1e9093
Author: Ilya Pekelny <email address hidden>
Date: Fri Mar 7 17:34:34 2014 +0200

    Fake logger as instance attribute

    Fake logger returned by fixtures.FakeLogger must be BaseTestCase instance
    attribute. Suchwise fake logger is accesible in BaseTestCase subclasses.

    Closes-Bug: #1289403
    Change-Id: I44afc23483f3bf0f031ba15d7f88e83b8be6f413

Changed in oslo:
status: In Progress → Fix Committed
Changed in oslo:
importance: Undecided → Medium
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in oslo:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in oslo:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.