xenapi: unable to create instances with ephemeral disks

[John Garbutt]

The resize ephemeral disk blueprint has regressed the ability to spawn instances with ephemeral disks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/78963

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/78963
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=527d9e532d1c2692fdd367314d98c37237ecc834
Submitter: Jenkins
Branch: master

commit 527d9e532d1c2692fdd367314d98c37237ecc834
Author: John Garbutt <email address hidden>
Date: Fri Mar 7 13:44:02 2014 +0000

    xenapi: fix spawn servers with ephemeral disks

    The new resize ephemeral disk code uses vdis["ephemerals"] to pass the
    list of ephemeral vdis to the resize disk code. This is shared between
    spawn and resize. As spawn wants to resize the root disk, resize=True
    during the spawn operation.

    The code in _attach_disks correctly deals with empty ephemeral disks,
    but the code in _resize_up_vdis did not, and failed due to
    ephemeral_vdis being None.

    This is a quick fix for the issue. We need some refactoring in this area
    so there is, ideally, only one place that generates ephemeral disks.

    Change-Id: If058c5c17c2ed76569fd98d4a3d8e5274721fbd0
    Closes-Bug: #1289361