run_tests requires selenium no matter if the flag --with-selenium is used

Bug #1289270 reported by Matthias Runge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Matthias Runge

Bug Description

When building horizon i-3 within a clean environment, no network connectivity, i.e. a build system):
+ ./run_tests.sh -N -P
Running Horizon application tests
SS.............................S..........................................................................
----------------------------------------------------------------------
Ran 106 tests in 81.812s
OK (SKIP=3)
nosetests --verbosity 1 horizon --nocapture --nologcapture --exclude-dir=horizon/conf/ --exclude-dir=horizon/test/customization --cover-package=horizon --cover-inclusive --all-modules
Creating test database for alias 'default'...
Destroying test database for alias 'default'...
Running openstack_dashboard tests
................................................................................................................................................SS...................SS.....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................SSS...............................................................................................................................................................................EE....................S.......
======================================================================
ERROR: Failure: ImportError (No module named selenium)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/loader.py", line 413, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/builddir/build/BUILD/horizon-2014.1.b3/openstack_dashboard/test/integration_tests/helpers.py", line 17, in <module>
    import selenium
ImportError: No module named selenium
======================================================================
ERROR: Failure: ImportError (No module named selenium.webdriver.common.keys)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/loader.py", line 413, in loadTestsFromName
    addr.filename, addr.module)
  File "/usr/lib/python2.7/site-packages/nose/importer.py", line 47, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/usr/lib/python2.7/site-packages/nose/importer.py", line 94, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/builddir/build/BUILD/horizon-2014.1.b3/openstack_dashboard/test/integration_tests/tests/test_login.py", line 15, in <module>
    import selenium.webdriver.common.keys as keys
ImportError: No module named selenium.webdriver.common.keys
nosetests --verbosity 1 openstack_dashboard --nocapture --nologcapture --cover-package=openstack_dashboard --cover-inclusive --all-modules
Creating test database for alias 'default'...
Destroying test database for alias 'default'...
----------------------------------------------------------------------
Ran 860 tests in 213.722s
FAILED (SKIP=8, errors=2)
Tests failed.
error: Bad exit status from /var/tmp/rpm-tmp.lhS6LB (%check)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.lhS6LB (%check)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.

Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78954

Changed in horizon:
assignee: nobody → Matthias Runge (mrunge)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/78954
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0ed2b041861acd6b2b74affc0aef4eb68f5a9706
Submitter: Jenkins
Branch: master

commit 0ed2b041861acd6b2b74affc0aef4eb68f5a9706
Author: Matthias Runge <email address hidden>
Date: Fri Mar 7 13:44:16 2014 +0100

    Fix selenium imports on tests

    tests require selenium to be installed, no matter if
    integration tests or selenium tests are executed or
    not.

    Change-Id: Ie55d64c19b00b5b22f62948d4a24a3f322082b0c
    Closes-Bug: #1289270

Changed in horizon:
status: In Progress → Fix Committed
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
importance: Medium → High
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.