BigSwitch: Cfg.error call formatted incorrectly

Bug #1289134 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton

Bug Description

In an exception handling case a config error is raised; however, the call is currently formatted incorrectly. It passes the details as a second parameter rather than performing the string formatting in place.

It also refers to strerror, which may not be present on all exception types that could be raised during the certificate retrieval.

https://github.com/openstack/neutron/blob/7255e056092f034daaeb4246a812900645d46911/neutron/plugins/bigswitch/servermanager.py#L358

Tags: bigswitch
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79046

Changed in neutron:
importance: Undecided → Medium
milestone: none → icehouse-rc1
tags: added: bigswitch
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/79046
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=84368554d8a13a421297298de40693956af25fcd
Submitter: Jenkins
Branch: master

commit 84368554d8a13a421297298de40693956af25fcd
Author: Kevin Benton <email address hidden>
Date: Fri Mar 7 10:41:24 2014 -0800

    BigSwitch: Fix cfg.Error format in exception

    Fixes an incorrectly formatted call to cfg.Error
    in an exception handling routine in the Big Switch
    server manager module.

    Closes-Bug: #1289134
    Change-Id: I9a1137d7395412ff6f061aacbe85f9b26269a1da

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.