Progress indicators in Resize Instance modal show incorrect values

[Vahid Hashemian]

Progress indicators in Resize Instance modal show two colors, blue for currently allocated and green for the allocation-to-be based on user's flavor choice. The problem is the current flavor is taken into account in blue, and the new flavor is taken into account in green. In other words, allocation numbers of two flavors for the same instance are included in the progress bar.

Suggestion is to exclude the current flavor from the blue piece, and use the new flavor for the green piece.

To reproduce the issue,
1. Launch an instance with m1.nano flavor.
2. Open the Resize Instance modal by clicking on More > Resize Instance next to the instance.
3. Select "m1.micro" for New Flavor.

You'll notice blue and green sections showing 1 for "Number of Instances", even though resizing is not supposed to change the number of instances.

Similarly, it shows 1 vcpu for blue and 1 for green, even though selecting m1.micro should not change the number of allocated vcpus.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/79112

[OpenStack Infra (hudson-openstack)]

Change abandoned by Julie Pichon (<email address hidden>) on branch: master
Review: https://review.openstack.org/79112
Reason: Author is no longer an active contributor.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/117053

[Gloria Gu (gloria-gu)]

Besides the issue reported in the description, I also fix the issue of flavor detail when no flavor selected.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/117053
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d433b9157672e3854d9e5cf2996da819320096d9
Submitter: Jenkins
Branch: master

commit d433b9157672e3854d9e5cf2996da819320096d9
Author: Gloria Gu <email address hidden>
Date: Tue Aug 26 16:08:35 2014 -0700

    Fixed issue of progress bars in resize instance

    When user resizes instance there are 4 issues for the progress
    (graphic) bars:

    1.It adds 1 instance even there is no new instance to add.
    2.It adds the vcpu of the selected flavor when it should have
    used the difference between the old flavor and new flavor.
    3. It adds the ram of the selected flavor when it should have
    used the difference of the old flavor and new flavor.
    4. When select no falvor, the new flavor detail doesn't get updated.

    Added logics to deal with flavor quota for instance_resize:

    1. Set a flag resize_instance in resize_instance.py where it passes
    the context back to _flavors_and_quotas.html.
    2. Seperate the instance progress bars using different ids based
    on the resize_instance flag.
    3. Updated horizon.quota.js to capture the old_flavor. When old_flavor
    and selected_flavor are both available, use the difference to caculate
    the update_amount for vcpu and ram.
    4. Instance update_amount is always 0 for resize instance case.
    5. When nothing selected in flavor choice, update the flavor detail to
    reflect that.

    What to expect now:

    When change to the flavor of size bigger, the instance bar should not
    change. The vCPU bar will be updated based on the new flavor. The RAM
    bar will be updated based on the new flavor.

    When change to the same flavor, the progress bars should not be updated.

    When user tries to resize to be smaller size, the progress bars
    will not change.

    Closes-Bug: #1288954
    Change-Id: Ie5bb47a4ea416864ed88b80b1c1c539c76f4bc49