Extra initialization in trove config class

Bug #1288864 reported by Dan Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Dan Nguyen

Bug Description

The following initialization is done 2x in /trove/common/cfg.py

CONF = cfg.CONF

CONF.register_opts(path_opts)
CONF.register_opts(common_opts)

I'm guessing this was cut and paste error?

https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L264-L267

https://github.com/openstack/trove/blob/master/trove/common/cfg.py#L393-L396

Changed in trove:
assignee: nobody → Dan Nguyen (daniel-a-nguyen)
Revision history for this message
Auston McReynolds (amcrn) wrote :

good catch dan. send the patch our way, and we'll quickly approve it.

Changed in trove:
status: New → Confirmed
milestone: none → icehouse-rc1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/79467

Changed in trove:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/79467
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=7cf3ad24c5ad5a79c03e0b036f9af1429bfce061
Submitter: Jenkins
Branch: master

commit 7cf3ad24c5ad5a79c03e0b036f9af1429bfce061
Author: daniel-a-nguyen <email address hidden>
Date: Mon Mar 10 14:41:37 2014 -0700

    Removes extra initialization from config

    Change-Id: I4105619166cce524b454c55bba1c5a1ca8112f54
    Closes-Bug: #1288864

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.