Missing slug in TabGroup gives confusing errors

Bug #1288650 reported by Radomir Dopieralski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Radomir Dopieralski

Bug Description

If the slug attribute is not defined on a TabGroup, the page is rendered properly, but switching the tabs doesn't work -- either giving confusing JavaScript errors about missing spinner, if preload = False, or just simply doing nothing, otherwise.

A NotImplementedError should be raised instead.

no longer affects: tuskar-ui
Changed in horizon:
assignee: nobody → Radomir Dopieralski (thesheep)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78951

Changed in horizon:
status: New → In Progress
David Lyle (david-lyle)
Changed in horizon:
milestone: none → icehouse-rc1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/78951
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ed3f76defd22bafe8604b44ffb3283cce96f58c5
Submitter: Jenkins
Branch: master

commit ed3f76defd22bafe8604b44ffb3283cce96f58c5
Author: Radomir Dopieralski <email address hidden>
Date: Fri Mar 7 07:28:48 2014 -0500

    Raise an error when no slug on tab group

    When a tab group has no slug defined, it behaves in very strange
    ways and the error is hard to find. This will make finding it much
    easier.

    Change-Id: I97c4cdc7a860e8c40ce17ee1a59384bbf85782ad
    Closes-bug: 1288650

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.