OpenStack Compute (nova)

backup operation should delete image if snapshot failed

Bug #1288574 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
jichenjc
OpenStack Compute (nova) 2014.2 "juno"
Icehouse
Fix Released
Undecided
ChangBo Guo(gcb)
OpenStack Compute (nova) 2014.1.3

Bug Description

when we snapshot an instance, we will use @delete_image_on_error to delete any failed snapshot
however, the image will not be removed by backup code flow, it will be an issue if too many backup failed
at last ,all useful image will be removed and we have only 'error' image left in host

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichencom (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78534

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/78534
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3824051b1e5618388a17c88867a3037397bc96b7
Submitter: Jenkins
Branch: master

commit 3824051b1e5618388a17c88867a3037397bc96b7
Author: jichenjc <email address hidden>
Date: Fri Feb 28 20:31:39 2014 +0800

    Delete image when backup operation failed on snapshot step

    when we snapshot an instance, we will use @delete_image_on_error to
    delete any failed snapshot, however, the image will not be removed
    by backup code flow, it will be an issue if too many backup failed
    at last ,all useful image will be removed and we have only 'error'
    image left in host

    Change-Id: Ib527ade86aef52a8445b57fa03fed434578c4204
    Closes-Bug: #1288574

Changed in nova:
status: In Progress → Fix Committed
ChangBo Guo(gcb) (glongwave)
tags: added: icehouse-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/102469

Russell Bryant (russellb)
Changed in nova:
milestone: none → juno-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/icehouse)

Reviewed: https://review.openstack.org/102469
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7ca83e81a5afd76cb8bf5333c09f3441c3293ee0
Submitter: Jenkins
Branch: stable/icehouse

commit 7ca83e81a5afd76cb8bf5333c09f3441c3293ee0
Author: jichenjc <email address hidden>
Date: Fri Feb 28 20:31:39 2014 +0800

    Delete image when backup operation failed on snapshot step

    when we snapshot an instance, we will use @delete_image_on_error to
    delete any failed snapshot, however, the image will not be removed
    by backup code flow, it will be an issue if too many backup failed
    at last ,all useful image will be removed and we have only 'error'
    image left in host

    Change-Id: Ib527ade86aef52a8445b57fa03fed434578c4204
    Closes-Bug: #1288574
    (cherry picked from commit 3824051b1e5618388a17c88867a3037397bc96b7)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.