patterns broken r13117

[David Mathog]

Updated to r13117 (with none of my patches) and patterns is terribly broken.

Draw a rectangle, select a pattern fill, no pattern. The fill goes to black. When the fill is applied what looks like an "X" shaped cross, a "o" handle, and a square handle all sometimes appear at the origin, in the upper left corner of the drawing area.

This may have something to do with having to build now with:

  ./configure --disable-strict-build

which I never did before. That issue is covered in bug #1239969.

[David Mathog (mathog)]

Ubuntu 12.04.4 LTS
gcc 4.6.3

[su_v (suv-lp)]

See
<http://thread.gmane.org/gmane.comp.graphics.inkscape.devel/42800/focus=42835>

(not related to build issues on your system).

[su_v (suv-lp)]

Setting bug status to 'In progress' based on Tav's reply on the mailing list.

[David Mathog (mathog)]

Reverted to 13048 and patterns worked again. So, as you say, not related to the build issue.

[David Mathog (mathog)]

Tav, please make a note in this bug when you fix the part about:

- A pattern fill is only visible if the object's pattern handles are
 positioned over the area of the initial tile, at the SVG origin.

etc.,

If I may be so bold, if a fix does not present itself shortly, perhaps you could roll back the changes discussed in the mailing list thread? Bug #1286407 was a pretty minor problem, whereas the problems caused by the patch to fix it are major, completely disrupting normal usage of patterns.

[Tavmjong Bah (tavmjong-free)]

Should be fixed in r13120.

[su_v (suv-lp)]

@Tav - thanks a lot for the quick response!

[ Closing as 'Fix released' (regression only in recent trunk), but leaving milestone set to 0.91 for now so that Bryce's bug-hunt script catches the report ]

[David Mathog (mathog)]

@Tav - yes, it looks like you got it. Patterns are working again in r13120.

One minor thing, and it has been like this since at least 0.48.4

1. create a solid filled rectangle.
2. change to the select (arrow) tool, select that rectangle.
3. change it to pattern fill (I used stripes)

the node tool icons (or whatever the proper terminology is) appear at the origin in the upper left corner.

4. deselect the rectangle
5. select the rectangle again and drag it down and to the right.
6. change to the node tool.

the node tool icons are displaced from the drawing origin by the same amount as the rectangle was moved.

That is a little strange since no matter where the rectangle was created on the drawing surface the node tool icons appeared at the drawing origin. This allows the odd situation where what appears to be the same rectangle can appear at a position on a drawing, but its pattern adjustment handles (node tool icons) can be pretty much anywhere.

I know it has been this way forever, but why is the pattern adjustment wired into the node tool? To the end user pattern adjustment would appear to have nothing to do with nodes. Maybe add rotation and scale sliders to the Fill and Stroke dialog when the pattern icon is selected, or set up a separate toolbar? (Text is like that, there is both a toolbar and a dialog.)

[su_v (suv-lp)]

@mathog: feature request for pattern UI in Fill&Stroke (including mockup) e.g. tracked in
- Bug #210442 “[wishlist] Precise setting of pattern parameters”
  <https://bugs.launchpad.net/inkscape/+bug/210442>

[David Mathog (mathog)]

We still have a problem.

1. open pattern1.svg (attached)
2. open a new window
3. select the object with a pattern fill in the first window
4. paste it into the second window.
5. second window, save as pattern1_bad.svg

The pattern is empty in the second window. The reason is because the "line" elements in the defs for pattern1.svg
do not make it into the new window.

r13266 with no local patches.

[su_v (suv-lp)]

@David - you already filed this as separate bug #1248282 (AFAIU the actual problem is the <use> element inside the pattern definition, because the referenced object is not transferred via clipboard).

[David Mathog (mathog)]

Oops right.