FWaaS tests don't delete firewalls

Bug #1288441 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Kevin Benton

Bug Description

When the tests for FWaaS create a firewall and then delete it, the firewall object is still in the database in a PENDING_DELETE state waiting for the agent to remove it. Parent objects then can't be deleted because the firewall object is dependent on them.

Currently, all of the tests just leave the parent objects by using no_delete[1], which leaves things in the database and could lead to potential conflicts later.

1. https://github.com/openstack/neutron/blob/ac8c0c645de001a0d074cdfd9448f9680a5d5e34/neutron/tests/unit/db/firewall/test_db_firewall.py#L732

Tags: fwaas
Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/78457

Changed in neutron:
status: New → In Progress
description: updated
Changed in neutron:
importance: Undecided → Medium
milestone: none → icehouse-rc1
tags: added: fwaas
Changed in neutron:
assignee: Kevin Benton (kevinbenton) → Akihiro Motoki (amotoki)
Akihiro Motoki (amotoki)
Changed in neutron:
assignee: Akihiro Motoki (amotoki) → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/78457
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1959092bca5646306cfec5303f43627e78f6e2d4
Submitter: Jenkins
Branch: master

commit 1959092bca5646306cfec5303f43627e78f6e2d4
Author: Kevin Benton <email address hidden>
Date: Tue Mar 4 03:27:11 2014 -0800

    Mock agent RPC for FWaaS tests to delete DB objs

    This changes the firewall service unit tests to
    mock the RPC calls from the firewall service to
    the agent. This allows the tests to fake the
    agent response RPC that removes the firewall
    from the DB so the all of the other objects that
    the firewall depends on can be deleted.

    Closes-Bug: #1288441
    Change-Id: I32462ab5557b9c52328bf6a23a12efc2d799644c

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.